Fix for app link redirect from CCT due to forced browser preference, Fixes AB#3387976 #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where app link redirects from Chrome Custom Tabs (CCT) were failing due to forced browser package preferences. The fix removes explicit package setting for browser intents to allow the system to properly handle app link redirects.
- Removes forced browser package assignment in CustomTabsManager
- Removes explicit package setting in SwitchBrowserActivity browser intent
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CustomTabsManager.java | Removes setPackage call that forced CCT to use specific browser package |
| SwitchBrowserActivity.kt | Removes explicit package setting on browser intent to allow system routing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
github-actions
bot
changed the title
melissaahn
approved these changes
Sep 29, 2025
p3dr0rv
reviewed
Sep 29, 2025
...c/main/java/com/microsoft/identity/common/internal/providers/oauth2/SwitchBrowserActivity.kt
Show resolved
Hide resolved
p3dr0rv
approved these changes
Sep 29, 2025
p3dr0rv
approved these changes
Sep 29, 2025
This was referenced Oct 2, 2025
shahzaibj
added a commit
that referenced
this pull request
Oct 2, 2025
…AB#3391792 (#2777) Fixes [AB#3391792](https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3391792) Related: #2775
shahzaibj
added a commit
that referenced
this pull request
Oct 2, 2025
…Intent, Fixes AB#3391792 (#2778) Fixes [AB#3391792](https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3391792) Related: #2775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#3387976
The previous fix seems to have addressed the issue only partially.
Previous fix: #2745
Basically what's happening is that even with that flag CCT will sometimes still launch the URL in browser and this is happening because we're setting the browser's pkg name explicitly on the intent which tells the OS that this MUST be opened in the browser.
Checked CCT logs and they print something like:
Launching in browser as Browser pkg was explicitly set on the IntentOnce we remove the explicit pkg name then OS finds the best possible app on the device to handle the intent. For an app link that's the the broker hosting app.